nixos/openssh: Add settings to comply with RFC42 #316111
Open
+158
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasJ
force-pushed
the
feat/openssh-client-settings
branch
from
9885e9b
to
901f486
Compare
dasJ
force-pushed
the
feat/openssh-client-settings
branch
from
901f486
to
73c53f3
Compare
Lassulus
reviewed
Jun 18, 2024
| ''; | ||
| matchSettings = lib.mkOption { | ||
| type = lib.types.attrsOf settingsNameValueType; | ||
| description = "Restricts declarations to be used only when the conditions are satisifed."; |
There was a problem hiding this comment.
is this something we came up our self or is there some upstream documentation we can reference here?
There was a problem hiding this comment.
It's adapted from man ssh_config. I'm not sure how much it would help to reference that entire man page in this option :/
Ma27
reviewed
Jun 18, 2024
| Specifies the host key algorithms that the client wants to use in order of preference. | ||
| ''; | ||
| matchSettings = lib.mkOption { | ||
| type = lib.types.attrsOf settingsNameValueType; |
There was a problem hiding this comment.
For Match blocks, ordering is important, isn't it? That's actually a reason against using attrsOf here.
There was a problem hiding this comment.
It is, that's why settingsNameValueType has a priority option ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.