tabiew: init at 0.3.4 #315711
Merged
tabiew: init at 0.3.4 #315711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
suggested changes
May 29, 2024
matteo-pacini
suggested changes
Jun 9, 2024
pkgs/by-name/ta/tabiew/package.nix
Outdated
| mainProgram = "tw"; | ||
| maintainers = with lib.maintainers; [ anas ]; | ||
| platforms = with lib.platforms; unix ++ windows; | ||
| broken = stdenv.isDarwin; # needing some apple_sdk packages |
There was a problem hiding this comment.
Compiles fine on aarch64-darwin just by removing broken = stdenv.isDarwin (?)
There was a problem hiding this comment.
Don't we need any apple_sdk packages?
There was a problem hiding this comment.
I don't think so, compiles fine on aarch64-darwin with this tiny patch:
diff --git a/pkgs/by-name/ta/tabiew/package.nix b/pkgs/by-name/ta/tabiew/package.nix
index 8051ecb48406..3c562a146666 100644
--- a/pkgs/by-name/ta/tabiew/package.nix
+++ b/pkgs/by-name/ta/tabiew/package.nix
@@ -37,6 +37,5 @@ rustPlatform.buildRustPackage rec {
mainProgram = "tw";
maintainers = with lib.maintainers; [ anas ];
platforms = with lib.platforms; unix ++ windows;
- broken = stdenv.isDarwin; # needing some apple_sdk packages
};
}
Tested it on a CSV file too, renders fine in the terminal
There was a problem hiding this comment.
updated, thanks for testing
AndersonTorres
approved these changes
Jun 15, 2024
h7x4
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add tabiew (tw) package, which is a lightweight, terminal-based application to view and query delimiter-separated value formatted documents, such as CSV and TSV files.
Try it
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.