nixos/services.kubernetes.kubelet: handle non-lower case chars in hostname #315144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jonpulsifer @vdemeester for potentially taking a look at this PR. |
|
I approve of this. I just wonder if it could potentially break anything for others that rely on the old behavior. Maybe a rel note is in order? |
|
Good idea. I can push a release note later today. Thanks. |
ae8c7d9
to
c20da95
Compare
c20da95
to
eae49a7
Compare
eae49a7
to
7c85dbe
Compare
|
@SuperSandro2000 I saw you reviewed as a committer on a recent PR in this module; can I ping you for a potential commit here as well? |
|
Looks like I better re-request review now that I fixed a merge conflict with the release notes so I can claim the approvals label. |
7c85dbe
to
65a7b76
Compare
65a7b76
to
88d9348
Compare
|
Apologies @vdemeester @johanot but could I bother either of you to re-up approval? I had to fix merge conflicts with the changelog update but everything else has remained the same. |
|
Ah, appreciate that Sandro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I discovered when enabling a minimally configured kubernetes master + node cluster on my computer that uppercase letters in the
networking.hostNameresult inkubeletbeing unauthorized to set a node up. The node name ends up being a lowercased version of the hostname and that mismatch causes problems.Errors are of the form:
It seems like the most straight forward answer is to lowercase the system hostname when using it as a default
kubelet.hostname. I also considered applying the lowercase function specifically where thekubelet.hostnameis used as part of theCNfor the relevant cert but seeing as how hostnames will always resolve as case insensitive there seems to be no reason not to apply it to thekubelet.hostnamewhich is then most likely to prevent any similar problems in the future regardless of where the hostname is used.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.