nixos/services.kubernetes.kubelet: handle non-lower case chars in hostname #315144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I discovered when enabling a minimally configured kubernetes master + node cluster on my computer that uppercase letters in the
networking.hostName
result inkubelet
being unauthorized to set a node up. The node name ends up being a lowercased version of the hostname and that mismatch causes problems.Errors are of the form:
It seems like the most straight forward answer is to lowercase the system hostname when using it as a default
kubelet.hostname
. I also considered applying the lowercase function specifically where thekubelet.hostname
is used as part of theCN
for the relevant cert but seeing as how hostnames will always resolve as case insensitive there seems to be no reason not to apply it to thekubelet.hostname
which is then most likely to prevent any similar problems in the future regardless of where the hostname is used.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.