Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver-bin: add wrapGAppsHook #315027

Merged
merged 1 commit into from
May 27, 2024
Merged

dbeaver-bin: add wrapGAppsHook #315027

merged 1 commit into from
May 27, 2024

Conversation

luoiuan
Copy link

@luoiuan luoiuan commented May 27, 2024

Description of changes

add wrapGAppsHook to nativeBuildInputs, for the app crashes when opening the file selection box

eg. create new connection -> select sqlite -> click open

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Naxdy
Copy link
Contributor

Naxdy commented May 27, 2024

Changes look good, but you can squash both commits, and indicate the scope of the change.

For example:

dbeaver-bin: add wrapGAppsHook

@Naxdy Naxdy requested review from mkg20001 and gepbird May 27, 2024 08:40
@luoiuan
Copy link
Author

luoiuan commented May 27, 2024

thanks for review, use wrapGAppsHook3 explicitly

@mkg20001 mkg20001 merged commit 8ad2c84 into NixOS:master May 27, 2024
26 of 27 checks passed
@Naxdy Naxdy added the backport release-24.05 Backport PR automatically label May 28, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants