srec: init at 0-unstable-2015-03-06

[simoneruffini]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true (as I know it's the default on linux)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[DontEatOreo]

Please rebase and reword your commit title to be srec: init at 0-unstable-2015-03-06 (Also reword your PR title)

Also please move your package to pkgs/by-name/sr/srec/package.nix and remove the package entry from pkgs/top-level/all-packages.nix

[simoneruffini]

Please rebase and reword your commit title to be srec: init at 0-unstable-2015-03-06 (Also reword your PR title)

Also please move your package to pkgs/by-name/sr/srec/package.nix and remove the package entry from pkgs/top-level/all-packages.nix

Why do I need to put in packages by name?

[DontEatOreo]

Please rebase and reword your commit title to be srec: init at 0-unstable-2015-03-06 (Also reword your PR title)
Also please move your package to pkgs/by-name/sr/srec/package.nix and remove the package entry from pkgs/top-level/all-packages.nix

Why do I need to put in packages by name?

nixpkgs/pkgs/README.md

Lines 134 to 142 in 6de51d9

	## Category Hierarchy
	[categories]: #category-hierarchy
	Most top-level packages are organised in a loosely-categorised directory hierarchy in this directory.
	See the [overview](#overview) for which directories are part of this.
	This category hierarchy is partially deprecated and will be migrated away over time.
	The new `pkgs/by-name` directory ([docs](./by-name/README.md)) should be preferred instead.
	The category hierarchy may still be used for packages that should be imported using an alternate `callPackage`, such as `python3Packages.callPackage` or `libsForQt5.callPackage`.

nixpkgs/pkgs/README.md

Line 141 in 6de51d9

The new `pkgs/by-name` directory ([docs](./by-name/README.md)) should be preferred instead.

[DontEatOreo]

Result of nixpkgs-review pr 314652 run on aarch64-darwin 1

1 package built:

• srec

[Lurkki14]

Suggested change

	installPhase = ''
	mkdir -p "$out/bin"
	cp bin2srec "$out/bin"
	cp srec2bin "$out/bin"
	'';
	installPhase = ''
	runHook preInstall
	mkdir -p "$out/bin"
	cp bin2srec "$out/bin"
	cp srec2bin "$out/bin"
	runHook postInstall
	'';

Suggested change

	installPhase = ''
	mkdir -p "$out/bin"
	cp bin2srec "$out/bin"
	cp srec2bin "$out/bin"
	'';
	installPhase = ''
	mkdir -p "$out/bin"
	cp bin2srec "$out/bin"
	cp srec2bin "$out/bin"
	'';