Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt: fix sbtn on apple-darwin #314226

Merged
merged 1 commit into from
Jun 8, 2024
Merged

sbt: fix sbtn on apple-darwin #314226

merged 1 commit into from
Jun 8, 2024

Conversation

rtimush
Copy link
Contributor

@rtimush rtimush commented May 24, 2024

Description of changes

sbt provides a universal binary for apple-darwin since 1.10 instead of separate aarch64 and x86_64 ones.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 24, 2024
@rtimush rtimush marked this pull request as ready for review May 24, 2024 08:53
@ofborg ofborg bot requested review from NeQuissimus and kashw2 May 24, 2024 09:21
@NickCao NickCao merged commit c65c72d into NixOS:master Jun 8, 2024
24 checks passed
@rtimush rtimush deleted the sbtn branch June 8, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants