iterm2: 3.4.23 → 3.5.2

[sikmir]

Description of changes

Changelog

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[zarthross]

• Using OpenAI's ChatGPT API, iTerm2 can now write
  commands for you, interpret the output of
  commands, and guide you towards a goal. See the
  AI section below for details.

There is serious debate in the Issue boards for iterm2 to disable these features by default, and it seems that even if you provide an invalid API key, some details about the terminal input is making its way to OpenAI.... I recommend we don't merge this release into Nix.

https://gitlab.com/gnachman/iterm2/-/issues/11475

[LeSuisse]

Includes the security fixes for the issues described in https://vin01.github.io/piptagole/escape-sequences/iterm2/hyper/url-handlers/code-execution/2024/05/21/arbitrary-url-schemes-terminal-emulators.html

[LeSuisse]

An additional security issue has been fixed in 3.5.2, see https://www.openwall.com/lists/oss-security/2024/06/15/1

The OpenAI part has been moved into a dedicated plugin in 3.5.1.

@sikmir Can you please bump this PR to 3.5.2 so can move forward?

https://iterm2.com/downloads/stable/iTerm2-3_5_2.changelog

[LeSuisse]

Took the opportunity to test this while I had my aarch64 laptop booted on macOS. Looks fine.

Flagging this to be backported since we cannot patch it.

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] iterm2: 3.4.23 → 3.5.2 #321341

[github-actions]

Git push to origin failed for release-24.05 with exitcode 1

[LeSuisse]

CVE-2024-38395 & CVE-2024-38396 have been assigned to the security issues.

https://www.openwall.com/lists/oss-security/2024/06/17/1