Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: 1.7.16 -> 1.7.18 #312356

Merged
merged 1 commit into from
Jun 16, 2024
Merged

containerd: 1.7.16 -> 1.7.18 #312356

merged 1 commit into from
Jun 16, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/containerd/versions.

meta.description for containerd is: A daemon to control runC

meta.homepage for containerd is: https://containerd.io/

meta.changelog for containerd is: https://github.com/containerd/containerd/releases/tag/v1.7.17

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.7.17 with grep in /nix/store/am41y1ynl5jncw1vqil5ibi2dkxqzwvf-containerd-1.7.17
  • found 1.7.17 in filename of file in /nix/store/am41y1ynl5jncw1vqil5ibi2dkxqzwvf-containerd-1.7.17
Rebuild report (if merged into master) (click to expand) 
22 total rebuild path(s)

22 package rebuild(s)

First fifty rebuilds by attrpath

airlift
apptainer
apptainer-overriden-nixos
charliecloud
containerd
devcontainer
docker
docker-gc
docker-sbom
docker_24
docker_25
docker_26
flintlock
fn-cli
nvidia-docker
pipework
python311Packages.jupyter-repo2docker
python312Packages.jupyter-repo2docker
singularity
singularity-overriden-nixos
udocker
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/am41y1ynl5jncw1vqil5ibi2dkxqzwvf-containerd-1.7.17 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A containerd https://github.com/r-ryantm/nixpkgs/archive/60d308ae4a8faf2678e5d9b8a23f9c9bcc02a3a5.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/60d308ae4a8faf2678e5d9b8a23f9c9bcc02a3a5#containerd

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/am41y1ynl5jncw1vqil5ibi2dkxqzwvf-containerd-1.7.17
ls -la /nix/store/am41y1ynl5jncw1vqil5ibi2dkxqzwvf-containerd-1.7.17/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

24 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • containerd
  • devcontainer
  • docker
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • flintlock
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist
Maintainer pings

cc @offlinehacker @vdemeester for testing.

@ofborg ofborg bot requested review from offlinehacker and vdemeester May 17, 2024 04:16
@matthiasbeyer
Copy link
Contributor

Result of nixpkgs-review pr 312356 run on x86_64-linux 1

1 package failed to build:
  • devcontainer
23 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • containerd
  • docker (docker_24)
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • flintlock
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

@matthiasbeyer
Copy link
Contributor

Not sure what to do about the devcontainer build failure, so I'll not merge this.

@r-ryantm r-ryantm changed the title containerd: 1.7.16 -> 1.7.17 containerd: 1.7.16 -> 1.7.18 Jun 10, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/containerd/containerd/releases.

meta.description for containerd is: Daemon to control runC

meta.homepage for containerd is: https://containerd.io/

meta.changelog for containerd is: https://github.com/containerd/containerd/releases/tag/v1.7.18

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.7.18 with grep in /nix/store/1l20l2950ws5d2imsnymahaclml38nma-containerd-1.7.18
  • found 1.7.18 in filename of file in /nix/store/1l20l2950ws5d2imsnymahaclml38nma-containerd-1.7.18
Rebuild report (if merged into master) (click to expand) 
22 total rebuild path(s)

22 package rebuild(s)

First fifty rebuilds by attrpath

airlift
apptainer
apptainer-overriden-nixos
charliecloud
containerd
devcontainer
docker
docker-gc
docker-sbom
docker_24
docker_25
docker_26
flintlock
fn-cli
nvidia-docker
pipework
python311Packages.jupyter-repo2docker
python312Packages.jupyter-repo2docker
singularity
singularity-overriden-nixos
udocker
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/1l20l2950ws5d2imsnymahaclml38nma-containerd-1.7.18 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A containerd https://github.com/r-ryantm/nixpkgs/archive/8df597b8fd725b2d714ef9c6679bc0cf44df8245.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/8df597b8fd725b2d714ef9c6679bc0cf44df8245#containerd

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/1l20l2950ws5d2imsnymahaclml38nma-containerd-1.7.18
ls -la /nix/store/1l20l2950ws5d2imsnymahaclml38nma-containerd-1.7.18/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package failed to build:
  • devcontainer
23 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • containerd
  • docker
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • flintlock
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist
Maintainer pings

cc @offlinehacker @vdemeester for testing.

@vdemeester
Copy link
Member

Result of nixpkgs-review pr 312356 run on x86_64-linux 1

1 package failed to build:
  • devcontainer
23 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • containerd
  • docker (docker_24)
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • flintlock
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

@vdemeester
Copy link
Member

See #314644 for devcontainer

@h7x4
Copy link
Member

h7x4 commented Jun 16, 2024

Merging, considering devcontainer already is broken

@h7x4 h7x4 merged commit 288dd94 into NixOS:master Jun 16, 2024
26 checks passed
@r-ryantm r-ryantm deleted the auto-update/containerd branch June 17, 2024 00:20
@seanrmurphy
Copy link
Contributor

@h7x4 - I guess that the devcontainer build was not working due to a kernel issse and it should prob be fixed when kernel 6.9.3 is used; I believe it has the same root cause as #314713.

@seanrmurphy
Copy link
Contributor

Looks like devcontainer is now building properly on hydra - https://hydra.nixos.org/job/nixpkgs/trunk/devcontainer.x86_64-linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @matthiasbeyer @vdemeester @h7x4 @seanrmurphy @wegank