linuxPackages.r8168: 8.052.01 -> 8.053.00, remove broken #311238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
reviewed
May 13, 2024
Co-authored-by: Weijia Wang <[email protected]>
|
@timokau would you mind reviewing? not sure if I'm missing something or if there's more I can do to help move this along. |
timokau
requested changes
May 24, 2024
There was a problem hiding this comment.
Thanks for the update, and also thanks for removing my outdated maintainer entry :)
You wrote that you verified that the github version still matches the official one, which source did you use for the official one? Please update the link in the comment, the current one seems broken.
|
thanks timokau. after following the download link(s) through realtek I diff'd with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bumping to latest r8168 module from mirror. Removed maintainer per their request and updated broken to match module's current compatibility with kernels up to 6.8.
Successfully built this module (without my changes) and applied it to an install (using allow broken) and it worked well. I'm not confident in the syntax I used for the
brokensetting, nor was I able to build this change locally (almost certainly because I don't know clearly what I'm doing - I triednix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD -p r8168"for example and it hung my terminal for a while then subsequently crashed)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)