Arcan updates #310831

AndersonTorres · 2024-05-11T12:22:21Z

Description of changes

Things done

Built on platform(s)
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
- sandbox = relaxed
- sandbox = true
Tested, as applicable:
- NixOS test(s) (look inside nixos/tests)
- and/or package tests
- or, for functions and "core" functionality, tests in lib/tests or pkgs/test
- made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
- (Package updates) Added a release notes entry if the change is major or breaking
- (Module updates) Added a release notes entry if the change is significant
- (Module addition) Added a release notes entry if adding a new NixOS module
Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

nixos-discourse · 2024-05-15T12:02:23Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3934

nixos-discourse · 2024-05-22T22:37:52Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3977

lucasew · 2024-05-23T11:37:43Z

Result of nixpkgs-review pr 310831 run on x86_64-linux 1

10 packages built:

arcan
arcan-all-wrapped
arcan-wrapped
cat9
cat9-wrapped
durden
durden-wrapped
pipeworld-wrapped
prio-wrapped
xarcan

nixos-discourse · 2024-05-30T14:28:55Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1704

useranon350 · 2024-06-01T21:29:54Z

I am curious why this is still using the upstream Tracy and not the forked one currently referenced in the arcan clone.sh. Is the clone.sh out of date?

AndersonTorres · 2024-06-02T02:18:14Z

TBH i did not notice it is now using an in-house copy.
Tomorrow I will fix this.

useranon350 · 2024-06-03T02:38:06Z

tracy worked for me by disabling libunwind using TRACY_LIBUNWIND_BACKTRACE.

AndersonTorres · 2024-06-07T01:10:53Z

It looks like a workaround rather than a real fixup.
I will keep it this way.

nixos-discourse · 2024-06-07T01:14:09Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1719

useranon350 · 2024-06-07T04:12:54Z

It looks like a workaround rather than a real fixup. I will keep it this way.

Yes, but it allows keeping Tracy support mostly functional, with only the libunwind backtraces not working. It should also be solvable by correctly adding libunwind to the build/runtime dependencies, but I don't know enough about Nix to debug why the obvious approach was not working.

AndersonTorres · 2024-06-07T12:55:40Z

Is there any serious lack of functionality by not building it with Tracy support?

useranon350 · 2024-06-07T21:56:57Z

You cannot use Tracy to debug problems and have to recompile it with print-logging to get equivalent information.

AndersonTorres · 2024-06-25T00:11:54Z

Google returned this:

https://groups.google.com/g/comp.lang.tcl/c/fgAfAFfiHPo?pli=1
https://fossil-scm.org/forum/forumpost/4f137684b0fc77af4d635ad60d790e8d56849a2b2a2ebc4c9d87ef8dac28c425
https://medium.com/@superseb/get-your-certificate-chain-right-4b117a9c0fce

AndersonTorres · 2024-06-25T01:21:44Z

For now I will revert (?) to the older GitHub.

pbsbot · 2024-06-28T12:00:33Z

Result of nixpkgs-review pr 310831 run on x86_64-linux 1

5 packages failed to build:

arcan-all-wrapped
cat9
cat9-wrapped
durden
durden-wrapped

5 packages built:

arcan
arcan-wrapped
pipeworld-wrapped
prio-wrapped
xarcan

AndersonTorres · 2024-06-28T12:09:30Z

cat9 and durden: I forgot them!

pbsds · 2024-06-28T12:17:35Z

It also seems to include some WIP commit, please ping me when you consider the PR ready :)

AndersonTorres · 2024-06-28T13:05:28Z

@ofborg build arcan-all-wrapped

AndersonTorres · 2024-06-28T13:34:02Z

Now it's fine! @pbsds

pbsds · 2024-06-28T14:37:35Z

where is letoram-tracy used?

pbsbot · 2024-06-28T14:39:16Z

Result of nixpkgs-review pr 310831 run on x86_64-linux 1

10 packages built:

arcan
arcan-all-wrapped
arcan-wrapped
cat9
cat9-wrapped
durden
durden-wrapped
pipeworld-wrapped
prio-wrapped
xarcan

AndersonTorres · 2024-06-28T14:57:25Z

where is letoram-tracy used?

It can be optionally used as an alternative to tracy.
Should it be more explicit, e.g. a flag?

pbsds · 2024-06-28T15:27:10Z

Perhaps make the sources import a default in the callPackage args which thus in turn can leverage the .override interface? Then arcan.override (old: { sources = old.sources // { tracy = old.sources.letoram-tracy; }) becomes possible

It is easier to control them this way, in order to not pollute the master package file. Also, let's put them on passthru.

AndersonTorres · 2024-06-28T18:05:01Z

sources as an argument? Nice!

- hammer-reorder - replace-fail - strictDeps - split outputs

Also update the external/git sources too.

The fork is somewhat broken.

pbsbot · 2024-06-28T21:24:17Z

Result of nixpkgs-review pr 310831 run on x86_64-linux 1

13 packages built:

arcan
arcan-all-wrapped
arcan-wrapped
arcan.dev
arcan.lib
arcan.man
cat9
cat9-wrapped
durden
durden-wrapped
pipeworld-wrapped
prio-wrapped
xarcan

AndersonTorres marked this pull request as ready for review May 11, 2024 12:22

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 11, 2024

AndersonTorres force-pushed the arcan branch from 943373b to 320181c Compare May 11, 2024 13:31

AndersonTorres mentioned this pull request May 11, 2024

xarcan: bump and add update script #307792

Merged

13 tasks

AndersonTorres mentioned this pull request May 25, 2024

xarcan: 0-unstable-2024-05-11 -> 0-unstable-2024-05-23 #314676

Closed

AndersonTorres added needs_merger awaiting_merger labels Jun 1, 2024

useranon350 mentioned this pull request Jun 1, 2024

Update Arcan and associated packages. Temporarily disable libunwind support added in new Arcan/Tracy versions. #316517

Closed

13 tasks

AndersonTorres force-pushed the arcan branch 8 times, most recently from 476059b to d3754eb Compare June 3, 2024 00:41

AndersonTorres force-pushed the arcan branch 2 times, most recently from 532673f to ab88fbd Compare June 25, 2024 00:05

AndersonTorres force-pushed the arcan branch from ab88fbd to f91e9ed Compare June 25, 2024 00:33

AndersonTorres force-pushed the arcan branch from f91e9ed to b69dc69 Compare June 26, 2024 13:13

AndersonTorres force-pushed the arcan branch 2 times, most recently from a50ea34 to 11b0efe Compare June 28, 2024 13:05

arcan: move sources to sources.nix

51e0ef8

It is easier to control them this way, in order to not pollute the master package file. Also, let's put them on passthru.

AndersonTorres force-pushed the arcan branch from 11b0efe to cc73100 Compare June 28, 2024 18:04

AndersonTorres added 5 commits June 28, 2024 15:12

arcan: refactor

dda2d76

- hammer-reorder - replace-fail - strictDeps - split outputs

arcan: 0.6.2.1-unstable-2023-11-18 -> 0.6.3

6a6ce22

Also update the external/git sources too.

arcan: declare upstream tracy alongside letoram fork

ed12d8f

The fork is somewhat broken.

durden: unstable-2023-10-23 -> 0-unstable-2024-06-23

cf8d0c3

cat9: unstable-2023-11-06 -> 0-unstable-2024-06-17

af2c0c8

AndersonTorres force-pushed the arcan branch from cc73100 to af2c0c8 Compare June 28, 2024 18:13

pbsds merged commit e001103 into NixOS:master Jun 28, 2024
23 of 24 checks passed

AndersonTorres self-assigned this Jun 28, 2024

AndersonTorres mentioned this pull request Jul 3, 2024

qmplay2: 24.04.07 -> 24.06.16 #321056

Open

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arcan updates #310831

Arcan updates #310831

AndersonTorres commented May 11, 2024

nixos-discourse commented May 15, 2024

nixos-discourse commented May 22, 2024

lucasew commented May 23, 2024

nixos-discourse commented May 30, 2024

useranon350 commented Jun 1, 2024

AndersonTorres commented Jun 2, 2024 •

edited

Loading

useranon350 commented Jun 3, 2024

AndersonTorres commented Jun 7, 2024 •

edited

Loading

nixos-discourse commented Jun 7, 2024

useranon350 commented Jun 7, 2024

AndersonTorres commented Jun 7, 2024

useranon350 commented Jun 7, 2024

AndersonTorres commented Jun 25, 2024

AndersonTorres commented Jun 25, 2024

pbsbot commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

pbsds commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

pbsds commented Jun 28, 2024

pbsbot commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024 •

edited

Loading

pbsds commented Jun 28, 2024 •

edited

Loading

AndersonTorres commented Jun 28, 2024

pbsbot commented Jun 28, 2024

Arcan updates #310831

Arcan updates #310831

Conversation

AndersonTorres commented May 11, 2024

Description of changes

Things done

nixos-discourse commented May 15, 2024

nixos-discourse commented May 22, 2024

lucasew commented May 23, 2024

nixos-discourse commented May 30, 2024

useranon350 commented Jun 1, 2024

AndersonTorres commented Jun 2, 2024 • edited Loading

useranon350 commented Jun 3, 2024

AndersonTorres commented Jun 7, 2024 • edited Loading

nixos-discourse commented Jun 7, 2024

useranon350 commented Jun 7, 2024

AndersonTorres commented Jun 7, 2024

useranon350 commented Jun 7, 2024

AndersonTorres commented Jun 25, 2024

AndersonTorres commented Jun 25, 2024

pbsbot commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

pbsds commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024

pbsds commented Jun 28, 2024

pbsbot commented Jun 28, 2024

AndersonTorres commented Jun 28, 2024 • edited Loading

pbsds commented Jun 28, 2024 • edited Loading

AndersonTorres commented Jun 28, 2024

pbsbot commented Jun 28, 2024

AndersonTorres commented Jun 2, 2024 •

edited

Loading

AndersonTorres commented Jun 7, 2024 •

edited

Loading

AndersonTorres commented Jun 28, 2024 •

edited

Loading

pbsds commented Jun 28, 2024 •

edited

Loading