Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

impression: 3.1.0 -> 3.2.0 #304701

Merged
merged 1 commit into from
Jun 15, 2024
Merged

impression: 3.1.0 -> 3.2.0 #304701

merged 1 commit into from
Jun 15, 2024

Conversation

dotlambda
Copy link
Member

Description of changes

Diff: https://gitlab.com/adhami3310/Impression/-/compare/v3.1.0...v3.2.0

depends on #291339

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@getchoo
Copy link
Member

getchoo commented May 30, 2024

Result of nixpkgs-review pr 304701 run on aarch64-linux 1

1 package built:
  • impression

@nadir-ishiguro
Copy link
Contributor

Result of nixpkgs-review pr 304701 run on x86_64-linux 1

1 package built:
  • impression

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4094

@h7x4 h7x4 merged commit c57102c into NixOS:master Jun 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants