firefox-bin: link native-messaging-hosts to correct location #303562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Apr 12, 2024
pasqui23
reviewed
Apr 12, 2024
9146b65
to
4579971
Compare
4579971
to
eb872b2
Compare
eb872b2
to
41afcb5
Compare
41afcb5
to
1a2a5aa
Compare
zeorin
reviewed
Jun 19, 2024
1a2a5aa
to
3aa629b
Compare
3aa629b
to
16a93b1
Compare
|
@jtojnar can we merge this PR? |
jtojnar
reviewed
Jul 12, 2024
| @@ -52,6 +52,7 @@ let | |||
| , extraPoliciesFiles ? [] | |||
| , libName ? browser.libName or "firefox" # Important for tor package or the like | |||
| , nixExtensions ? null | |||
| , hasMozSystemDirPatch ? (lib.hasPrefix "firefox" pname && lib.hasSuffix "-bin" pname) | |||
There was a problem hiding this comment.
Should not this be !lib.hasSuffix "-bin" pname?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #47340
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.