Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazysql: init at 0.1.8 #303238

Merged
merged 2 commits into from
Jun 16, 2024
Merged

lazysql: init at 0.1.8 #303238

merged 2 commits into from
Jun 16, 2024

Conversation

kanielrkirby
Copy link
Contributor

@kanielrkirby kanielrkirby commented Apr 10, 2024 •
edited

Description of changes

Adding the lazysql package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bbenno
Copy link
Member

bbenno commented Jun 15, 2024

Result of nixpkgs-review pr 303238 run on x86_64-linux 1

1 package built:
  • lazysql

h7x4
h7x4 reviewed Jun 15, 2024
View reviewed changes
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/by-name/la/lazysql/package.nix Outdated Show resolved Hide resolved
@kanielrkirby
Copy link
Contributor Author

Should be good @h7x4!

@h7x4
Copy link
Member

h7x4 commented Jun 15, 2024 •
edited

Sorry, could you squash the last two prs into a single commit named lazysql: init at 0.1.8? There are some commit guidelines in place. The changes themselves look good, but I have not tested the tool

@kanielrkirby
Copy link
Contributor Author

My bad there. It's been a bit since I've made this one and I completely forgot about the guidelines 😅 Should (hopefully) be good now.

@h7x4 h7x4 merged commit c9c0e6a into NixOS:master Jun 16, 2024
23 checks passed
@h7x4 h7x4 added the backport release-24.05 Backport PR automatically label Jun 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jun 16, 2024
Merged
1 task
@kanielrkirby kanielrkirby deleted the new-pkg/lazysql branch June 17, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h7x4 h7x4 h7x4 left review comments

Assignees
No one assigned
Labels
8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kanielrkirby @bbenno @h7x4