Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdg-utils: add xdg-terminal #290860

Merged
merged 1 commit into from
Mar 23, 2024
Merged

xdg-utils: add xdg-terminal #290860

merged 1 commit into from
Mar 23, 2024

Conversation

chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Feb 23, 2024 •
edited
Loading

Description of changes

Add xdg-terminal to xdg-utils

Closes #290691

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from edolstra February 23, 2024 13:47
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review February 23, 2024 22:06
SuperSandro2000
SuperSandro2000 reviewed Feb 23, 2024
View reviewed changes
pkgs/tools/X11/xdg-utils/default.nix Outdated Show resolved Hide resolved
pkgs/tools/X11/xdg-utils/default.nix Outdated Show resolved Hide resolved
@chewblacka chewblacka force-pushed the fix2-xdg-utils branch 2 times, most recently from 73c6849 to 2c7c1fc Compare February 24, 2024 11:52
@chewblacka chewblacka requested a review from 0x4A6F March 20, 2024 14:03
@mkg20001 mkg20001 merged commit 628282d into NixOS:staging Mar 23, 2024
24 checks passed
@eclairevoyant eclairevoyant mentioned this pull request Apr 4, 2024
Closed
@chewblacka chewblacka deleted the fix2-xdg-utils branch April 7, 2024 07:43
@chewblacka chewblacka mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@eclairevoyant eclairevoyant Awaiting requested review from eclairevoyant

@Artturin Artturin Awaiting requested review from Artturin

@0x4A6F 0x4A6F Awaiting requested review from 0x4A6F

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chewblacka @SuperSandro2000 @delroth @mkg20001