opengfw: init at 0.4.0 (+NixOS module) #290008
Open
+460
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eum3l
changed the title
eum3l
force-pushed
the
add-opengfw
branch
3 times, most recently
from
9d16c94
to
cb0e29f
Compare
eum3l
force-pushed
the
add-opengfw
branch
2 times, most recently
from
8e894b6
to
82ab699
Compare
|
Please update the title, and squash comment |
eum3l
changed the title
eum3l
force-pushed
the
add-opengfw
branch
3 times, most recently
from
a2a7154
to
a7a00c4
Compare
eum3l
changed the title
|
Please split the maintainers and application comment |
eum3l
changed the title
eum3l
force-pushed
the
add-opengfw
branch
3 times, most recently
from
1792ae7
to
c99b4d5
Compare
eum3l
force-pushed
the
add-opengfw
branch
3 times, most recently
from
faab516
to
5c53905
Compare
eum3l
changed the title
eum3l
changed the title
eum3l
force-pushed
the
add-opengfw
branch
2 times, most recently
from
b73c238
to
d0a4346
Compare
eum3l
force-pushed
the
add-opengfw
branch
2 times, most recently
from
19f44a7
to
93dd63a
Compare
eum3l
force-pushed
the
add-opengfw
branch
2 times, most recently
from
00a8901
to
7d1148b
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4116 |
0x61nas
reviewed
Jun 21, 2024
0x61nas
suggested changes
Jun 21, 2024
eum3l
force-pushed
the
add-opengfw
branch
2 times, most recently
from
5b5162e
to
b908938
Compare
|
Result of 1 package blacklisted:
1 package built:
|
JohnRTitor
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Built NixOS manual looks good. @Aleksanaa do you want to take a look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.