Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog: 0.6.0 -> 0.7.1 #289608

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from
Draft

glog: 0.6.0 -> 0.7.1 #289608

wants to merge 3 commits into from
+24 −2

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/google/glog/releases.

meta.description for glog is: Library for application-level logging

meta.homepage for glog is: https://github.com/google/glog

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.7.0 with grep in /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0
  • found 0.7.0 in filename of file in /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0
Rebuild report (if merged into master) (click to expand) 
2182 total rebuild path(s)

2182 package rebuild(s)

First fifty rebuilds by attrpath
ansible-doctor
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
arrow-cpp
arrow-glib
asn1editor
authentik
barman
beancount
breezy
brise
browsr
buck
buildbot
buildbot-full
buildbot-ui
cabal2nix
caffe
caffeWithCuda
calcurse
cantor
ceph
ceph-client
ceph-csi
ceph-dev
ceres-solver
certbot-full
cfripper
chatgpt-retrieval-plugin
cloudcompare
coconut
colmap
colmapWithCuda
conan
crackmapexec
csvkit
databricks-sql-cli
datalad
dbx
deface
deja-dup
dep2nix
devpi-client
dnstwist
dragonflydb
duplicity
duply
dvc
dvc-with-remotes
dwarfs
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A glog https://github.com/r-ryantm/nixpkgs/archive/d851940e3c16fc1dde937e3608ef6eb10d4dbfe0.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/d851940e3c16fc1dde937e3608ef6eb10d4dbfe0#glog

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0
ls -la /nix/store/msbn00ykbswj5ri1q0avh8g5pdsv4z2n-glog-0.7.0/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @nh2 @r-burns for testing.

@ofborg ofborg bot requested review from nh2 and r-burns February 17, 2024 22:55
@marsam
Copy link
Contributor

marsam commented Mar 28, 2024

@GrahamcOfBorg eval

@wegank wegank marked this pull request as draft April 5, 2024 18:35
@r-ryantm r-ryantm changed the title glog: 0.6.0 -> 0.7.0 glog: 0.6.0 -> 0.7.1 Jun 13, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/google/glog/releases.

meta.description for glog is: Library for application-level logging

meta.homepage for glog is: https://github.com/google/glog

Updates performed
  • Version update
To inspect upstream changes
Impact

Checks done

  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.7.1 with grep in /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1
  • found 0.7.1 in filename of file in /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1
Rebuild report (if merged into master) (click to expand) 
3334 total rebuild path(s)

3334 package rebuild(s)

First fifty rebuilds by attrpath

anki
ansible-doctor
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
arrow-cpp
arrow-glib
asn1editor
authentik
backgroundremover
barman
beancount
breezy
brise
browsr
buck
buildbot
buildbot-full
buildbot-ui
buildbotPackages.buildbot
buildbotPackages.buildbot-full
buildbotPackages.buildbot-ui
cabal2nix
caffe
caffeWithCuda
calcurse
cantor
ceph
ceph-client
ceph-csi
ceph-dev
ceres-solver
certbot-full
cfripper
chatgpt-retrieval-plugin
cloudcompare
coconut
colmap
colmapWithCuda
conan
crackmapexec
databricks-sql-cli
datalad
datatrove
dbx
deface
deja-dup
dep2nix
devpi-client
dnstwist
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A glog https://github.com/r-ryantm/nixpkgs/archive/8f4ecc04ffefa41e9b10ca6699431101d5894212.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/8f4ecc04ffefa41e9b10ca6699431101d5894212#glog

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1
ls -la /nix/store/qlkrndcx0w5j2szzrvmp2rcc3map37x3-glog-0.7.1/bin

Pre-merge build results

NixPkgs review skipped

Maintainer pings

cc @nh2 @r-burns for testing.

@nh2
Copy link
Contributor

nh2 commented Jun 23, 2024 •
edited
Loading

I started building the direct dependents of glog using:

nix-build --no-out-link $(nix-store -q --referrers $(nix-instantiate -A glog)) --keep-going

Failures:

folly-2024.03.11.00

In file included from /build/source/folly/CancellationToken-inl.h:23,
                 from /build/source/folly/CancellationToken.h:365,
                 from /build/source/folly/CancellationToken.cpp:17:
/nix/store/9y0cswrb58vw8vshmi14mrs4v9lqs25c-glog-0.7.1/include/glog/logging.h:60:4: error: #error <glog/logging.h> was not included correctly. See the documentation for how to consume the library.
   60 | #  error <glog/logging.h> was not included correctly. See the documentation for how to consume the library.
      |    ^~~~~

Looks like:

I commented there that AUR has a patch, applying that here fixes that.

It further needed this patch I made:

I pushed 2 patches into this PR that fixes those. I hope that works with r-ryantm's workflows.

Other failed packages

caffe-1.0
dwarfs-0.9.9
gnss-sdr-0.0.19.1
lomiri-download-manager-0.1.3
mir-2.15.0
natron-2.5.0
python3.11-opensfm-unstable-2023-12-09
python3.12-opensfm-unstable-2023-12-09
trust-store-2.0.2

Many of them have similar error messages as folly had.

See also:

@ofborg ofborg bot requested review from pierreis and abbradar June 23, 2024 15:25
@nh2
Copy link
Contributor

nh2 commented Jun 23, 2024

Running out of time; somebody else would have to take a look at the remaining build failures, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

@r-burns r-burns Awaiting requested review from r-burns

@pierreis pierreis Awaiting requested review from pierreis

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-ryantm @marsam @nh2