kafka: versions cleanup and drop older #287036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For clarity, my intention is to ignore the pkgs/by-name check failure. 😸 |
|
Please don't! Check out #285922 (comment) for my recommendation on what to do |
No problem and thanks for the advice. How does it look to you now? :) |
0eb6a7d
to
e76cfa6
Compare
|
Looking good regarding |
e76cfa6
to
d2b1ce1
Compare
|
@srhb Hey, could you please rebase this against master and then cherry-pick my three commits from https://github.com/jpds/nixpkgs/commits/kafka-versions-cleanup-3.7/ ? |
SuperSandro2000
approved these changes
Jun 13, 2024
General cleanup -- following the logic that NixOS 23.11 contains Kafka 3.5, so there is a sensible upgrade path for everyone as long as we keep that around until after the next release.
To please the by-name gods :-)
d2b1ce1
to
ff5e9d2
Compare
|
@jpds Done, how does this look? 😸 |
|
Looks great to me (though I do not have commit privileges to merge this myself). |
SuperSandro2000
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds new version, cleans up everything not necessary to have a sane upgrade experience on NixOS.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.