-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetbrains.plugins: add AsciiDoc, StringManipulation, AceJump, Mermaid and AWS toolkit #285605
Conversation
fb0dc3a
to
607cc0c
Compare
@edwtjo can we get this merged? |
607cc0c
to
39a68b8
Compare
39a68b8
to
0ae3a0b
Compare
33e8d34
to
42ca2e4
Compare
42ca2e4
to
5aeb86c
Compare
@liff I tried to built this locally in order to verify this change. I have a local checkout of nixpkgs and cherry picked the commits from this PR to that checkout. I configured my IntelliJ package like so:
However when building my system I get
It looks like aws toolkit was moved and the URL is returning 301 now:
Any idea how to fix that? |
5aeb86c
to
df8eaea
Compare
@britter looks like a new major version of AWS Toolkit was released, which probably changed stuff. I’ve updated the plugins, can you check again? |
df8eaea
to
5e756c1
Compare
5e756c1
to
c533559
Compare
c533559
to
fb881d8
Compare
@liff sorry, this took forever... I tried again today with the latest changes, replacing the nixpkgs-unstable input in my flake this this PR branch. I got a different error this time, I'm not sure it's related to your changes. It looks like a problem with the environment that builds some parts of the IDE:
I'd really love to get this integrated, but at this point I'm not sure how to help :( |
Turns out this is unrelated to the PR. I also get this when updating to the latest nixpkgs-unstable. It looks like building idea-community is currently broken on unstable. |
fb881d8
to
92f2ec7
Compare
Rebased. |
I tested this by checking out this PR locally and replacing my nixpkgs-unstable output with it. After starting IntelliJ, I could see all the plugins as being bundled with the IDE. All of them were enabled. So from my PoV this is good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
Result of |
Result of |
Result of |
Result of |
Description of changes
Add a bunch of useful(?) plugins:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.