Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.mpris-server: 0.8.1 -> 0.4.2; revert python-updates #280668

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2024

downgrade mpris-server to support python < 3.12

mpris-server version 0.8+ uses python 3.12 typing syntax downgrade to a version which still supports python 3.11

Result of nixpkgs-review run on x86_64-linux 1

5 packages built:
  • monophony
  • python311Packages.mpris-server
  • python311Packages.mpris-server.dist
  • python312Packages.mpris-server
  • python312Packages.mpris-server.dist

testing: ran monophony, played a song.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • aarch64-darwin
    • x86_64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@mweinelt
Copy link
Member

mweinelt commented Jan 13, 2024

As written on the issue, the syntax used was introduced in Python 3.12 and the author is probably unaware. Could you update your commit message to say as much?

Ideally we could send a patch upstream to reestablish support for 3.11.

mpris-server version 0.8+ uses python 3.12 typing syntax downgrade to a
version which still supports python 3.11
@ghost ghost force-pushed the mpris-server-downgrade branch from 56f4743 to 4f8902a Compare January 13, 2024 13:38
@ghost
Copy link
Author

ghost commented Jan 13, 2024

As written on the issue, the syntax used was introduced in Python 3.12 and the author is probably unaware. Could you update your commit message to say as much?

ah -- that makes much more sense. commit message updated.

@mweinelt mweinelt merged commit 42ff80b into NixOS:master Jan 13, 2024
4 of 5 checks passed
@ghost ghost deleted the mpris-server-downgrade branch January 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant