djview: 4.10.6 -> 4.12

[6t8k]

Description of changes

Changelog: https://sourceforge.net/p/djvu/djview-git/ci/release.4.12/tree/NEWS

The release tarball no longer contains a configure script, so pull in the necessary dependencies to generate it here.

Disable building the nsdejavu plugin as modern browsers have dropped support for NPAPI. The npdjvu plugin is based on NPAPI too, so remove the respective note.

Split man output from out.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[6t8k]

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

• djview
• djview.man

[6t8k]

Addendum: changed meta.license from licenses.gpl2 to licenses.gpl2Plus.

I currently have no means to test whether djview is (still) broken on Darwin.

[Anton-Latukha]

Code changes are concise and simple, I approve.

[pbsds]

when merged with master:

error:
       … while calling the 'listToAttrs' builtin

         at /nix/store/0anpglz0hkcvl5plw9wy628pcjn786p7-nixpkgs-review-2.10.3/lib/python3.11/site-packages/nixpkgs_review/nix/evalAttrs.nix:46:1:

           45|
           46| listToAttrs (concatMap getProperties attrs)
             | ^
           47|

       … while calling the 'concatMap' builtin

         at /nix/store/0anpglz0hkcvl5plw9wy628pcjn786p7-nixpkgs-review-2.10.3/lib/python3.11/site-packages/nixpkgs_review/nix/evalAttrs.nix:46:14:

           45|
           46| listToAttrs (concatMap getProperties attrs)
             |              ^
           47|

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'mainProgram' already defined at /dev/shm/nixpkgs-review/pr-267944/nixpkgs/pkgs/applications/graphics/djview/default.nix:57:5

       at /dev/shm/nixpkgs-review/pr-267944/nixpkgs/pkgs/applications/graphics/djview/default.nix:62:5:

           61|     maintainers = with maintainers; [ Anton-Latukha ];
           62|     mainProgram = "djview";
             |     ^
           63|     longDescription = ''

I assume some other PR must've already added mainProgram

[6t8k]

I assume some other PR must've already added mainProgram

Right, looks to be ff1a94e - I've removed the line here and rebased. Still builds and runs fine on x86_64-linux, the initial comment remains accurate.