Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.kmonad: unbreak #267450

Merged

Conversation

slotThe
Copy link
Contributor

@slotThe slotThe commented Nov 14, 2023

Description of changes

Version 0.4.2 was released on Hackage, which builds correctly.

Closes: #266186
Closes: #224190

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Version 0.4.2 was released on hackage, which builds correctly.

Closes: NixOS#266186
Closes: NixOS#224190
@sternenseemann
Copy link
Member

@ofborg build haskellPackages.kmonad

@sternenseemann sternenseemann merged commit 13a5e59 into NixOS:haskell-updates Nov 16, 2023
6 of 9 checks passed
@slotThe slotThe deleted the haskell/kmonad-unbreak branch November 16, 2023 18:09
slotThe added a commit to kmonad/kmonad that referenced this pull request Dec 22, 2023
As promised in [1], this makes gitHash a little more robust.

[1]: NixOS/nixpkgs#267450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants