Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocmPackages.hsa-amd-aqlprofile-bin: 5.7.0 -> 5.7.1 #262750

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Oct 22, 2023

Tracking: #197885

Made a nice little update script for this finally.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Madouura
Copy link
Contributor Author

Result of nixpkgs-review pr 262750 run on x86_64-linux 1

2 packages built:
  • rocmPackages.hsa-amd-aqlprofile-bin (rocmPackages_5.hsa-amd-aqlprofile-bin)
  • rocmPackages.rocprofiler (rocmPackages_5.rocprofiler)

@pbsds
Copy link
Contributor

pbsds commented Oct 23, 2023

Tried the update script via nix-update -u ..., and it works. The ELF binaries in results/rocmPackages.hsa-amd-aqlprofile-bin/lib/ however are not marked executable.

Added update script that actually works
@Madouura
Copy link
Contributor Author

Didn't notice that, thank you for noting it!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2816

@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 262750 run on x86_64-linux 1

2 packages built:
  • rocmPackages.hsa-amd-aqlprofile-bin (rocmPackages_5.hsa-amd-aqlprofile-bin)
  • rocmPackages.rocprofiler (rocmPackages_5.rocprofiler)

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbsds pbsds merged commit 1ce5a44 into NixOS:master Oct 26, 2023
23 checks passed
@Madouura Madouura deleted the pr/hsa-amd-aqlprofile branch October 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants