Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipcub: 5.4.4 -> 5.6.1 #252262

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

  • WARNING: Package has meta.broken=true; Please manually test this package update and remove the broken attribute.

meta.description for hipcub is: Thin wrapper library on top of rocPRIM or CUB

meta.homepage for hipcub is: https://github.com/ROCmSoftwarePlatform/hipCUB

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 5.6.1 with grep in /nix/store/y65ssa78q790w6vj3lhz2fdqx1pq6j1v-hipcub-5.6.1
  • found 5.6.1 in filename of file in /nix/store/y65ssa78q790w6vj3lhz2fdqx1pq6j1v-hipcub-5.6.1

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
hipcub
python310Packages.torchWithRocm
python311Packages.torchWithRocm
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/y65ssa78q790w6vj3lhz2fdqx1pq6j1v-hipcub-5.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A hipcub https://github.com/r-ryantm/nixpkgs/archive/02cae4af7b67a9397db52945deaf0c0e3a18a6bc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/y65ssa78q790w6vj3lhz2fdqx1pq6j1v-hipcub-5.6.1
ls -la /nix/store/y65ssa78q790w6vj3lhz2fdqx1pq6j1v-hipcub-5.6.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages marked as broken and skipped:
  • hipcub
  • python310Packages.torchWithRocm
  • python311Packages.torchWithRocm

Maintainer pings

cc @Madouura @Flakebi for testing.

@ofborg ofborg bot requested review from Madouura and Flakebi August 30, 2023 04:33
@wegank wegank marked this pull request as draft August 30, 2023 18:20
@Madouura Madouura mentioned this pull request Oct 5, 2023
12 tasks
@r-ryantm r-ryantm deleted the auto-update/hipcub branch October 10, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant