Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vamp-plugin-sdk: disable parallelism to avoid build failures #249621

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

uninsane
Copy link
Contributor

@uninsane uninsane commented Aug 16, 2023

Description of changes

  • upstream issue: make -j fails on high core count machine vamp-plugins/vamp-plugin-sdk#12
  • before this patch, i tried building this 4 times on a 24 core machine (.#pkgsCross.aarch64-multiplatform.vamp-plugin-sdk), and all 4 builds failed. signatures like:
    • aarch64-unknown-linux-gnu-ld: error: ./libvamp-hostsdk.a: file too short
    • aarch64-unknown-linux-gnu-ld: ./libvamp-hostsdk.a: error adding symbols: no more archived files
  • with this patch, it builds first try.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 17, 2024
@Artturin
Copy link
Member

Updated the issue link

@Artturin Artturin merged commit bdbba9e into NixOS:master Jul 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants