Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno: 1.32.3 -> 1.32.4 #226158

Merged
merged 1 commit into from
Apr 15, 2023
Merged

deno: 1.32.3 -> 1.32.4 #226158

merged 1 commit into from
Apr 15, 2023

Conversation

06kellyjac
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac mentioned this pull request Apr 14, 2023
Merged
12 tasks
@levex levex mentioned this pull request Apr 14, 2023
Closed
levex
levex approved these changes Apr 15, 2023
View reviewed changes
Copy link

@levex levex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

risicle
risicle approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15 & nixos x86_64

@risicle risicle merged commit f9c0db5 into NixOS:master Apr 15, 2023
@06kellyjac 06kellyjac deleted the deno branch April 15, 2023 22:00
@mlyxshi
Copy link
Contributor

mlyxshi commented Apr 17, 2023

aarch64 build fail
https://hydra.nixos.org/build/216127367

@06kellyjac
Copy link
Member Author

06kellyjac commented Apr 18, 2023 •
edited
Loading

Upstream issue

denoland/fastwebsockets#2
denoland/deno#18684

Once the PR is merged oh it is merged lol. I'll look to pick this up as a patch, but this week & next are a bit busy so patience is appreciated :)

@mlyxshi
Copy link
Contributor

mlyxshi commented Apr 18, 2023

https://github.com/denoland/deno/releases/tag/v1.32.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@levex levex levex approved these changes

@teutat3s teutat3s teutat3s approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@06kellyjac @mlyxshi @risicle @levex @teutat3s