Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocfft: actually fix hydra caching #214339

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Feb 3, 2023

Description of changes

This was tricky, but I can definitely confirm hydra will cache this since it turns out collecting garbage will show if the base derivation is still there or not, and if it is not then the new one (which should still exist) no longer depends on it.
Tracking: #197885

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Madouura
Copy link
Contributor Author

Madouura commented Feb 3, 2023

Result of nixpkgs-review pr 214339 run on x86_64-linux 1

3 packages built:
  • hipfft
  • python310Packages.torchWithRocm
  • rocfft

@mweinelt mweinelt merged commit 9eee238 into NixOS:master Feb 4, 2023
@Madouura Madouura deleted the pr/rocfft branch February 4, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants