Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers/team-list: add rocm team #199574

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Nov 4, 2022

Description of changes

Add rocm team for easier maintainability for ROCm(-related) packages.
There are a lot of rocm packages, and more coming.
Also @NixOS/rocm-maintainers for reviewing.
First time messing around with this, so tell me if you think this is a good or bad idea.
Tracking: #197885

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

mweinelt commented Nov 5, 2022

lgtm.

@Madouura Madouura marked this pull request as ready for review November 6, 2022 03:14
@Madouura
Copy link
Contributor Author

cc @Flakebi
Do you want to be added to this list as well?

@Flakebi
Copy link
Member

Flakebi commented Nov 12, 2022

Yes, that would be nice!

@mweinelt mweinelt merged commit dceb185 into NixOS:master Nov 12, 2022
@Madouura Madouura deleted the pr/rocm-team branch November 12, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants