Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/languages-frameworks/rust: example for disabling tests #198705

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Oct 30, 2022

Description of changes

Add an example for disabling test for rust.

There are two prevalent invocations in checkFlags:

  • "--skip=testname"
    rg -l 'buildRustPackage' pkgs | xargs rg -l 'skip=' | wc -l -> 43
  • "--skip testname"
    rg -l 'buildRustPackage' pkgs | xargs rg -l 'skip ' | wc -l -> 24
  • "--skip" "testname"
    rg -l 'buildRustPackage' pkgs | xargs rg -l 'skip" ' | wc -l -> 1
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Oct 30, 2022

Is there any upstream documentation on the --skip argument? I'd probably go with the style that's used there, not what's mostly used in nixpkgs.

@figsoda
Copy link
Member

figsoda commented Oct 31, 2022

"--skip testname" is wrong, it's either "--skip=testname" or "--skip" "testname"

@fricklerhandwerk fricklerhandwerk merged commit b37df78 into NixOS:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants