Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/languages-frameworks/*: add missing languages to code fences #116257

Merged
merged 1 commit into from
Apr 5, 2021
Merged

doc/languages-frameworks/*: add missing languages to code fences #116257

merged 1 commit into from
Apr 5, 2021

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 13, 2021 •
edited
Loading

Motivation for this change

vim didn't show me fency rendered code blocks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

@jtojnar PTAL

jtojnar
jtojnar reviewed Mar 15, 2021
View reviewed changes
doc/languages-frameworks/python.section.md Outdated
@@ -145,7 +145,7 @@ print(f"The dot product of {a} and {b} is: {np.dot(a, b)}")
Executing this script requires a `python3` that has `numpy`. Using what we learned
in the previous section, we could startup a shell and just run it like so:

```
```shell
nix-shell -p 'python38.withPackages(ps: with ps; [ numpy ])' --run 'python3 foo.py'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prompt ($) is missing here

jtojnar
jtojnar reviewed Mar 15, 2021
View reviewed changes
doc/languages-frameworks/rust.section.md Outdated
@@ -2,7 +2,7 @@

To install the rust compiler and cargo put

```
```shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Nix fragment.

@SuperSandro2000
Copy link
Member Author

If there is still something off we can fix it in another PR. I don't want this PR to collect merge conflicts.

@SuperSandro2000 SuperSandro2000 merged commit 3a6116c into NixOS:master Apr 5, 2021
@SuperSandro2000 SuperSandro2000 deleted the code-fences branch April 5, 2021 03:38
@jtojnar
Copy link
Member

jtojnar commented Apr 5, 2021

Looks good. Thanks for tackling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@jtojnar jtojnar jtojnar left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: agda 6.topic: python 6.topic: qt/kde 6.topic: rust 6.topic: vim 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @jtojnar @grahamc