Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path based redirects #9459

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Nov 27, 2023

Motivation

up to now, those were managed outside of this repo, which was
unsurprisingly a real hassle to deal with if one wanted to prevent existing links
from breaking when moving pages around. this change removes a large part
of the friction involved in moving content in the Nix manual.

Context

NixOS/nix.dev#764

possible next steps for further automation:

  • check for content that moved and warn if it's not reachable from
    links that were valid prior to a change
  • create redirect rules automatically based on this information

Priorities

Add 馃憤 to pull requests you find important.

up to now, those were managed outside of this repo, which as
unsurprisingly a real hassle to deal with if one wanted to prevent URLs
from breaking when moving pages around. this change removes a large part
of the friction involved in moving content in the Nix manual.

possible next steps for further automation:
- check for content that moved and warn if it's not reachable from
  links that were valid prior to a change
- create redirect rules automatically based on this information
@fricklerhandwerk fricklerhandwerk added backport 2.13-maintenance Automatically creates a PR against the branch backport 2.14-maintenance Automatically creates a PR against the branch backport 2.15-maintenance Automatically creates a PR against the branch backport 2.16-maintenance Automatically creates a PR against the branch backport 2.17-maintenance Automatically creates a PR against the branch backport 2.18-maintenance Automatically creates a PR against the branch backport 2.19-maintenance Automatically creates a PR against the branch labels Nov 27, 2023
@tomberek tomberek merged commit 0c6fe1b into NixOS:master Nov 27, 2023
17 checks passed
Copy link

Successfully created backport PR for 2.13-maintenance:

Copy link

Successfully created backport PR for 2.14-maintenance:

Copy link

Successfully created backport PR for 2.15-maintenance:

Copy link

Successfully created backport PR for 2.16-maintenance:

Copy link

Successfully created backport PR for 2.17-maintenance:

Copy link

Successfully created backport PR for 2.18-maintenance:

Copy link

Successfully created backport PR for 2.19-maintenance:

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-11-27-nix-team-meeting-minutes-107/36112/1

@fricklerhandwerk fricklerhandwerk deleted the page-redirects branch February 6, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.13-maintenance Automatically creates a PR against the branch backport 2.14-maintenance Automatically creates a PR against the branch backport 2.15-maintenance Automatically creates a PR against the branch backport 2.16-maintenance Automatically creates a PR against the branch backport 2.17-maintenance Automatically creates a PR against the branch backport 2.18-maintenance Automatically creates a PR against the branch backport 2.19-maintenance Automatically creates a PR against the branch documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants