Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for repl formatting with and without :p #8840

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

iFreilicht
Copy link
Contributor

@iFreilicht iFreilicht commented Aug 17, 2023

Motivation

Tests are good.

Context

Only tests were added, confirming the current behavior and preventing future regressions.

This is part of my work on #8672. As the path to take there is not trivial, it makes sense to merge the obvious improvement separately.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • documentation in the internal API docs
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

Priorities

Add 👍 to pull requests you find important.

@iFreilicht iFreilicht changed the title Test repl formatting with and without :p Add tests for repl formatting with and without :p Aug 17, 2023
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Aug 17, 2023
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@roberth roberth merged commit ba28613 into NixOS:master Aug 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants