Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build without GC #7874

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix the build without GC #7874

merged 1 commit into from
Feb 21, 2023

Conversation

Ericson2314
Copy link
Member

Motivation

I had given it an improper trailing comma in
1bd03ad.

Context

1bd03ad is from #7748

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

@Ericson2314
Fix the build without GC
5b0175e 
I had given it an improper trailing comma in
1bd03ad.
thufschmitt
thufschmitt approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erk, nasty CPP 🙃

@thufschmitt thufschmitt merged commit 8418d22 into NixOS:master Feb 21, 2023
@Ericson2314 Ericson2314 deleted the fix-no-gc-build branch February 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@thufschmitt thufschmitt thufschmitt approved these changes

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

@tomberek tomberek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @tomberek @thufschmitt