Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait with making /etc unwritable until after build env setup #7856

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

yorickvP
Copy link
Contributor

Motivation

The builder child still has to touch /etc to setup nsswitch.conf and bind mounts. Wait until after this to make /etc unwritable.

Context

Fixes #7852. Was broken in #7830.

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

@yorickvP
Copy link
Contributor Author

nix flake check passes.

@cole-h
Copy link
Member

cole-h commented Feb 17, 2023

(Since the previous fix that this amends was also backported to 2.12 and 2.13, please add those labels here, @ whichever maintainer gets to this first :D)

Copy link
Member

@thufschmitt thufschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thufschmitt thufschmitt merged commit 532c70f into NixOS:master Feb 21, 2023
@Artturin Artturin added backport 2.12-maintenance Automatically creates a PR against the branch backport 2.13-maintenance Automatically creates a PR against the branch labels Feb 21, 2023
@github-actions
Copy link

Git push to origin failed for 2.12-maintenance with exitcode 1

@github-actions
Copy link

Successfully created backport PR for 2.12-maintenance:

@github-actions
Copy link

Successfully created backport PR for 2.13-maintenance:

@github-actions
Copy link

Git push to origin failed for 2.13-maintenance with exitcode 1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.12-maintenance Automatically creates a PR against the branch backport 2.13-maintenance Automatically creates a PR against the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests.nssPreload is broken
5 participants