Remove CPU locking #5821
Merged
Remove CPU locking #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already accidentally disabled in ba87b08. It also no longer appears to be beneficial, and in fact slow things down, e.g. when evaluating a NixOS system configuration: elapsed time: median = 3.8170 mean = 3.8202 stddev = 0.0195 min = 3.7894 max = 3.8600 [rejected, p=0.00000, Δ=0.36929±0.02513]
86478a2
to
9747ea8
Compare
|
LGTM. Nothing that can go wrong without being catched by the compiler. I made sure to look closely at the daemon protocol part. That one may go wrong. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-24/17230/1 |
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Feb 25, 2022
Presumably these were required for compilation at some point, but have been removed in Nix 2.6: NixOS/nix#5821
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Feb 25, 2022
Presumably these were required for compilation at some point, but have been removed in Nix 2.6: NixOS/nix#5821
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Feb 25, 2022
Presumably these were required for compilation at some point, but have been removed in Nix 2.6: NixOS/nix#5821
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Feb 25, 2022
Presumably these were required for compilation at some point, but have been removed in Nix 2.6: NixOS/nix#5821
roberth
added a commit
to hercules-ci/hercules-ci-agent
that referenced
this pull request
Feb 25, 2022
Presumably these were required for compilation at some point, but have been removed in Nix 2.6: NixOS/nix#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Feb 5, 2023
Left over from 9747ea8, NixOS#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Feb 5, 2023
Left over from 9747ea8, NixOS#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Apr 7, 2023
Left over from 9747ea8, NixOS#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Apr 7, 2023
Left over from 9747ea8, NixOS#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Apr 7, 2023
Left over from 9747ea8, NixOS#5821
roberth
added a commit
to hercules-ci/nix
that referenced
this pull request
Apr 7, 2023
Left over from 9747ea8, NixOS#5821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already accidentally disabled in ba87b08. It also no longer appears to be beneficial, and in fact slow things down, e.g. when evaluating a NixOS system configuration:
Fixes #3345. Closes #3346.