lint: fix shellcheck for misc/systemv/nix-daemon #11103
Conversation
Got shellcheck passing for misc/systemv/nix-daemon Not sure how to test this since it's not running on my NixOS machine and I see no references to it in the directory otherwise. See NixOS#10795
| @@ -324,6 +324,7 @@ | |||
| ++ pkgs.nixComponents.nix-external-api-docs.nativeBuildInputs | |||
| ++ [ | |||
| pkgs.buildPackages.cmake | |||
| pkgs.shellcheck | |||
There was a problem hiding this comment.
I wanted to run shellcheck myself manually.
Shellcheck has a diff output style that you can try to apply for auto fixes for lots of cases now
shellcheck misc/systemv/nix-daemon -f diff | git apply
| . /etc/init.d/functions | ||
|
|
||
| LOCKFILE=/var/lock/subsys/nix-daemon | ||
| RUNDIR=/var/run/nix | ||
| PIDFILE=${RUNDIR}/nix-daemon.pid | ||
| RETVAL=0 | ||
|
|
||
| base=${0##*/} |
There was a problem hiding this comment.
warning from shellcheck that this has no reference.
Oof. If we don't have the tests to maintain this file, maybe we shouldn't pretend to. Or would this be used in, say, NixBSD? Do they have a test infra we could reuse? |
|
Cool -- in the meantime i'll pickup a different script. |
|
Not used there. |
It's from 8 years ago with the description that it's for BSD. |
Motivation
Got shellcheck passing for misc/systemv/nix-daemon
Not sure how to test this since it's not running on my NixOS machine and I see no references to it in the directory otherwise.
Context
See #10795
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.