[WIP] fix NIX_PATH for real
#11079
Draft
[WIP] fix NIX_PATH for real
#11079
+156
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just to show the principle. the test cases are incomplete and way too manual.
github-actions
bot
added
the
with-tests
Mic92
reviewed
Jul 11, 2024
| @@ -70,11 +70,9 @@ Strings EvalSettings::getDefaultNixPath() const | |||
| } | |||
| }; | |||
|
|
|||
| if (!restrictEval && !pureEval) { | |||
There was a problem hiding this comment.
Could you add to the commit message how this change fixes the issue? I am trying to understand how this relates to nix-path.
There was a problem hiding this comment.
Yeah it's still WIP, there will be rationale in the log.
This particular piece gets obsolete because allowed prefixes are handled in the source accessor now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with @roberth
Motivation
closes #9574
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.