Remove comparator.hh and switch to <=> in a bunch of places
#10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
edolstra
approved these changes
Jun 3, 2024
Ericson2314
force-pushed
the
spaceship-no-comparator
branch
from
c82645c
to
2861ad2
Compare
Ericson2314
force-pushed
the
spaceship-no-comparator
branch
from
2861ad2
to
f8a83b2
Compare
|
@tfc Do you have any idea what's going on with this macOS failure? I gather |
Ericson2314
force-pushed
the
spaceship-no-comparator
branch
from
f8a83b2
to
3a3cd54
Compare
Ericson2314
force-pushed
the
spaceship-no-comparator
branch
2 times, most recently
from
7434918
to
7d84ab9
Compare
Known behavior changes: - `MemorySourceAccessor`'s comparison operators no longer forget to compare the `SourceAccessor` base class. Progress on NixOS#10832 What remains for that issue is hopefully much easier!
Ericson2314
force-pushed
the
spaceship-no-comparator
branch
from
7d84ab9
to
bc83b9d
Compare
|
OK yay, this passed finally:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Progress on #10832
What remains for that issue is hopefully much easier!\
Context
Known behavior changes:
MemorySourceAccessor's comparison operators no longer forget to compare theSourceAccessorbase class.Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.