fix: bounds check result in getMaxCPU #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomberek
approved these changes
Mar 7, 2024
Closed
roberth
added
the
backport 2.18-maintenance
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-10172-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-10172-to-2.18-maintenance
git switch --create backport-10172-to-2.18-maintenance
git cherry-pick -x 9c64a09c709e3f995d7f24cdd5a69435c08488fc |
lf-
added a commit
to lix-project/lix
that referenced
this pull request
Apr 28, 2024
Upstream-Bug: NixOS/nix#9725 Upstream-PR: NixOS/nix#10172 Change-Id: I2b8e8b15ee28951be98e5cbe3ccea5b9c8de5994
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-daemon-service-wont-start-but-sudo-nix-daemon-works/46072/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9725
Motivation
Nix would do out of bounds reads if the kernel puts nothing in cpu.max, which is the case in certain patched kernels.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.