Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set builtins.nixVersion to a constant? #5970

Open
edolstra opened this issue Jan 24, 2022 · 2 comments
Open

Set builtins.nixVersion to a constant? #5970

edolstra opened this issue Jan 24, 2022 · 2 comments
Labels
bug stale

Comments

@edolstra
Copy link
Member

builtins.nixVersion is an impurity that can cause evaluation results to differ between Nix versions, see NixOS/nixpkgs#156527. So we could set it to a fixed value like 2.6. It's not clear whether there is a legitimate use case for builtins.nixVersion.
@edolstra edolstra added the bug label Jan 24, 2022
@bjornfor
Copy link
Contributor

bjornfor commented Jan 24, 2022 •
edited
Loading

Did you see this use-case? nix-community/poetry2nix@5c06704. (Arguably should not be needed, but here we are.)

@edolstra
Copy link
Member Author

Yeah regressions should be fixed.

edolstra added a commit to edolstra/nix that referenced this issue Jan 24, 2022
@edolstra
In pure mode, set builtins.nixVersion to a constant
74ffa32 
This prevents issues like
NixOS/nixpkgs#156527. Eventually we should do
this in impure mode as well. Issue NixOS#5970.
@edolstra edolstra mentioned this issue Jan 24, 2022
Open
@tomprince tomprince mentioned this issue Feb 14, 2022
Merged
@stale stale bot added the stale label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjornfor @edolstra