Allow unit test infra to be reused across libs' tests

This allows using Arbitrary "instances" defined in libstore-tests in libexpr-tests, something we will leverage in a moment.
NixOS · Jan 29, 2023 · ec0c0ef · ec0c0ef
1 parent 6772e9e
commit ec0c0ef
Show file tree

Hide file tree

Showing 13 changed files with 50 additions and 21 deletions.
diff --git a/.gitignore b/.gitignore
@@ -37,14 +37,14 @@ perl/Makefile.config
 /src/libexpr/parser-tab.hh
 /src/libexpr/parser-tab.output
 /src/libexpr/nix.tbl
-/src/libexpr/tests/libexpr-tests
+/src/libexpr/tests/libnixexpr-tests
 
 # /src/libstore/
 *.gen.*
-/src/libstore/tests/libstore-tests
+/src/libstore/tests/libnixstore-tests
 
 # /src/libutil/
-/src/libutil/tests/libutil-tests
+/src/libutil/tests/libnixutil-tests
 
 /src/nix/nix
 

diff --git a/src/libexpr/tests/error_traces.cc b/src/libexpr/tests/error_traces.cc
@@ -1,7 +1,7 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
-#include "libexprtests.hh"
+#include "tests/libexpr.hh"
 
 namespace nix {
 

diff --git a/src/libexpr/tests/json.cc b/src/libexpr/tests/json.cc
@@ -1,4 +1,4 @@
-#include "libexprtests.hh"
+#include "tests/libexpr.hh"
 #include "value-to-json.hh"
 
 namespace nix {

diff --git a/src/libexpr/tests/libexprtests.hh → src/libexpr/tests/libexpr.hh b/src/libexpr/tests/libexprtests.hh → src/libexpr/tests/libexpr.hh
@@ -7,18 +7,19 @@
 #include "eval-inline.hh"
 #include "store-api.hh"
 
+#include "tests/libstore.hh"
 
 namespace nix {
- class LibExprTest : public ::testing::Test {
+ class LibExprTest : public LibStoreTest {
  public:
  static void SetUpTestSuite() {
- initLibStore();
+ LibStoreTest::SetUpTestSuite();
  initGC();
  }
 
  protected:
  LibExprTest()
- : store(openStore("dummy:https://"))
+ : LibStoreTest()
  , state({}, store)
  {
  }
@@ -36,7 +37,6 @@ namespace nix {
  return state.symbols.create(value);
  }
 
- ref<Store> store;
  EvalState state;
  };
 

diff --git a/src/libexpr/tests/local.mk b/src/libexpr/tests/local.mk
@@ -2,6 +2,8 @@ check: libexpr-tests_RUN
 
 programs += libexpr-tests
 
+libexpr-tests_NAME := libnixexpr-tests
+
 libexpr-tests_DIR := $(d)
 
 libexpr-tests_INSTALL_DIR :=
@@ -12,6 +14,6 @@ libexpr-tests_SOURCES := \
 
 libexpr-tests_CXXFLAGS += -I src/libexpr -I src/libutil -I src/libstore -I src/libexpr/tests
 
-libexpr-tests_LIBS = libexpr libutil libstore libfetchers
+libexpr-tests_LIBS = libstore-tests libexpr libutil libstore libfetchers
 
 libexpr-tests_LDFLAGS := $(GTEST_LIBS) -lgmock
diff --git a/src/libexpr/tests/primops.cc b/src/libexpr/tests/primops.cc
@@ -1,7 +1,7 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 
-#include "libexprtests.hh"
+#include "tests/libexpr.hh"
 
 namespace nix {
  class CaptureLogger : public Logger

diff --git a/src/libexpr/tests/trivial.cc b/src/libexpr/tests/trivial.cc
@@ -1,4 +1,4 @@
-#include "libexprtests.hh"
+#include "tests/libexpr.hh"
 
 namespace nix {
  // Testing of trivial expressions

diff --git a/src/libexpr/tests/value/context.cc b/src/libexpr/tests/value/context.cc
@@ -1,6 +1,6 @@
 #include "value/context.hh"
 
-#include "libexprtests.hh"
+#include "tests/libexpr.hh"
 
 namespace nix {
 

diff --git a/src/libstore/tests/libstoretests.hh → src/libstore/tests/libstore.hh b/src/libstore/tests/libstoretests.hh → src/libstore/tests/libstore.hh
diff --git a/src/libstore/tests/local.mk b/src/libstore/tests/local.mk
@@ -1,6 +1,20 @@
-check: libstore-tests_RUN
+check: libstore-tests-exe_RUN
 
-programs += libstore-tests
+programs += libstore-tests-exe
+
+libstore-tests-exe_NAME = libnixstore-tests
+
+libstore-tests-exe_DIR := $(d)
+
+libstore-tests-exe_INSTALL_DIR :=
+
+libstore-tests-exe_LIBS = libstore-tests
+
+libstore-tests-exe_LDFLAGS := $(GTEST_LIBS)
+
+libraries += libstore-tests
+
+libstore-tests_NAME = libnixstore-tests
 
 libstore-tests_DIR := $(d)
 

diff --git a/src/libstore/tests/path.cc b/src/libstore/tests/path.cc
@@ -7,7 +7,8 @@
 #include "path-regex.hh"
 #include "store-api.hh"
 
-#include "libstoretests.hh"
+#include "tests/libstore.hh"
+#include "tests/path.hh"
 
 namespace nix {
 
@@ -73,11 +74,6 @@ void showValue(const StorePath & p, std::ostream & os) {
 namespace rc {
 using namespace nix;
 
-template<>
-struct Arbitrary<StorePath> {
- static Gen<StorePath> arbitrary();
-};
-
 Gen<StorePath> Arbitrary<StorePath>::arbitrary()
 {
  auto len = *gen::inRange<size_t>(1, StorePath::MaxPathLen);

diff --git a/src/libstore/tests/path.hh b/src/libstore/tests/path.hh
@@ -0,0 +1,15 @@
+#pragma once
+
+#include <rapidcheck.h>
+
+#include "path.hh"
+
+namespace rc {
+using namespace nix;
+
+template<>
+struct Arbitrary<StorePath> {
+ static Gen<StorePath> arbitrary();
+};
+
+}
diff --git a/src/libutil/tests/local.mk b/src/libutil/tests/local.mk
@@ -2,6 +2,8 @@ check: libutil-tests_RUN
 
 programs += libutil-tests
 
+libutil-tests_NAME := libnixutil-tests
+
 libutil-tests_DIR := $(d)
 
 libutil-tests_INSTALL_DIR :=