Skip to content

Commit

Permalink
daemon: Warn on old clients passing unexpected plugin-files.
Browse files Browse the repository at this point in the history
The setting itself was already ignored due to exception trying to set pluginFiles.
  • Loading branch information
shlevy committed Feb 2, 2023
1 parent 92edc38 commit 895c525
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/libstore/daemon.cc
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,10 @@ struct ClientSettings
// the daemon, as that could cause some pretty weird stuff
if (parseFeatures(tokenizeString<StringSet>(value)) != settings.experimentalFeatures.get())
debug("Ignoring the client-specified experimental features");
} else if (name == settings.pluginFiles.name) {
if (tokenizeString<Paths>(value) != settings.pluginFiles.get())
warn("Ignoring the client-specified plugin-files.\n"
"The client specifying plugins to the daemon never made sense, and was removed in Nix >=2.14.");
}
else if (trusted
|| name == settings.buildTimeout.name
Expand Down

0 comments on commit 895c525

Please sign in to comment.