Small fixes for the development environment #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5db374c the `bootstrap` script was removed, however it's still referenced in the contribution guidelines. Change that to `autoreconfPhase` as intended by the commit.
In 1bd195a strictDeps was set for the Hydra package. As a result, `checkInputs` aren't available anymore in the local dev-shell which is the sole purpose of foreman, to start services and a database for development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Ericson2314
doc/manual: fix instructions in contribution guidelines
In 5db374c the
bootstrapscript wasremoved, however it's still referenced in the contribution guidelines.
Change that to
autoreconfPhaseas intended by the commit.package: move foreman to nativeCheckInputs
In 1bd195a strictDeps was set for the
Hydra package. As a result,
checkInputsaren't available anymore inthe local dev-shell which is the sole purpose of foreman, to start
services and a database for development.