Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfinished: support ed25519 #74

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

Unfinished: support ed25519 #74

wants to merge 17 commits into from

Conversation

szszszsz
Copy link
Member

This is unfinished work to support ed25519, described in #39.
It works on freshly flashed devices, however when the last stable firmware is upgraded with it, the device fails to boot.
The latter has to be solved before merging in this PR.

  1. Since this code was not touched for a longer time, it might introduce some new issues, or revive old ones. Test with care.
  2. This is the first release containing linked Rust code for the ed25519 support. This comes with new problems and tests.
  3. Likely this won't fit into the smaller Nitrokey FIDO2 128kB, unless the available Resident Keys space would be significantly decreased.

Help wanted to develop and test this code. See #39 for the details.

conorpp and others added 17 commits July 21, 2021 18:15
@conorpp @szszszsz
compare only credId when comparing rk creds to allowList
d1eb583 
(cherry picked from commit d2293de)
@enrikb @szszszsz
Add salty to .gitmodules.
189d877 
This will be used for upcoming support of ED25519 in the 'Solo' version.

(cherry picked from commit 27e1e78)
@enrikb @szszszsz
Add Rust to travis and to the toolchain container.
6c9f72b 
Not sure if this is the way to do it...

Make salty build.

(cherry picked from commit 398943d)
@enrikb @szszszsz
POC: add ed25519 support based on libsodium (PC) or salty (solo).
d4ca7fc 
For now:

- libsodium(-dev) is expected to be preinstalled on build system for PC
build

(cherry picked from commit fe24b9e)
@enrikb @szszszsz
Bump salty to 809cdf009fa52d97adb292a8547d13c9015d6a06.
1d8d72c 
This version contains the scalar fix (see
ycrypto/salty#3).

(cherry picked from commit 3963c93)
@enrikb @szszszsz
ed25519: revert message buffer optimization.
7afb0ea 
(cherry picked from commit 3ee801b)
@enrikb @szszszsz
salty: cast pointer arguments to avoid warnings.
3de24f4 
This is a kind of promise that the underlying buffers have the correct
size. We know what we are doing. Hopefully ;-)

(cherry picked from commit 471df2a)
@Ollrogge @szszszsz
fix make all target
5fa542c 
(cherry picked from commit ac11eff)
@jdohm @szszszsz
Added Path variable to Dockerfile
afd6454 
Added the Path variable to the Dockerfile. Thisway the arm-none-eabi-gcc can be called without the user knowing the PATH.

(cherry picked from commit c924da3)
@szszszsz
REMOVE disable 128kB build for now
e946180
@szszszsz
REMOVE hardcode dev HWREV, and allow to flash any firmware
1346baa
@szszszsz
Add development-related documentation
53e3c4c
@szszszsz
Helper: show last built firmware while flashing
bdd7f69
@szszszsz
Add salty as a dependency to the main target
57f0eaf
@szszszsz
Docs: correct typos
61d252d
@conorpp @szszszsz
remove unused sections from salty pooling at the end of firmware
ee18add
@conorpp @szszszsz
linker discards
a8da471
@szszszsz szszszsz added enhancement New feature or request help wanted Extra attention is needed priority:low labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed priority:low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szszszsz @conorpp @enrikb @Ollrogge @jdohm