Missing file existence check for $TMP_DEFAULT_HASH_FILE #2
Comments
|
Unfortunately, I am not sure if I can add something useful here, currently... |
|
In case you would have any ideas what could cause the file to be missing, that would be very helpful! |
daringer
pushed a commit
that referenced
this issue
Jun 1, 2022
…be making CircleCI fail in the past days. Heads build system is reextracting archives and reapplying patches on each iteration. CircleCI optimizes building time by providing cache mechanisms and forces users to build a target under an hour. This is to force Open Source projects (free tier) to not be leechers of the free tier. In the past days, CircleCI bails on building coreboot 4.11 boards because some files being cached are already being present (created files from patches). In those, two files were unwanted artifacts, recreated on top of coreboot 4.11 extracted original files (undesired .orig files), while bailing on the creating of src/security/tpm/sha1.c from patches/coreboot-4.11/0001-Add-Heads-TPM-measured-boot-support.patch. Hopefully, this is CircleCI having a maximum of 3 automatically entered input (it fails on the 3rd)... And this fix will permit src/security/tpm/sha1.c and src/security/tpm/sha1.h to be skipped if existing. Below, we see that CircleCI fills patch prompts with EOF 2 times, and then waits for input and then timeouts. Here is the failing log trace from https://app.circleci.com/pipelines/github/tlaurion/heads/990/workflows/f2a430fd-dc8c-4e95-abe3-364a0e825533/jobs/4914/parallel-runs/0/steps/0-103: Exerpt of that log: if [ -d patches/coreboot-4.11 ] && [ -r patches/coreboot-4.11 ] ; then for patch in patches/coreboot-4.11/*.patch ; do echo "Applying patch file : $patch " ; ( cd /root/project/build/coreboot-4.11/ ; patch -p1 ) < $patch || exit 1 ; done ; fi Applying patch file : patches/coreboot-4.11/0000-cpu-x86-smm-Use-PRIxPTR-to-print-uintptr_t.patch patching file src/cpu/x86/smm/tseg_region.c Applying patch file : patches/coreboot-4.11/0001-Add-Heads-TPM-measured-boot-support.patch patching file src/Kconfig The next patch would create the file src/Kconfig.orig, which already exists! Assume -R? [n] EOF Apply anyway? [n] EOF Skipping patch. 1 out of 1 hunk ignored patching file src/include/program_loading.h patching file src/lib/cbfs.c patching file src/lib/hardwaremain.c Hunk #2 succeeded at 549 (offset 8 lines). patching file src/lib/rmodule.c patching file src/security/tpm/Makefile.inc The next patch would create the file src/security/tpm/sha1.c, which already exists! Assume -R? [n] make: *** [Makefile:507: /root/project/build/coreboot-4.11/.canary] Hangup context deadline exceeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
User reported that his boot was stopping after
+++ Checking verified default boot hash filemessage (left for 3-4 hours powered on). I think the most probable cause is the following line:heads/initrd/bin/kexec-select-boot
Line 236 in 624faa1
Assuming
$TMP_DEFAULT_HASH_FILEvariable would be empty this ends with infinite waiting for the input, similarly for calling justsha256sum -c.It should be checked before whether this variable is not empty.
The text was updated successfully, but these errors were encountered: