Skip to content

Commit

Permalink
Prepare for the 1.1.0 release. Fix 2 checkstyle warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
jnizet committed Sep 22, 2013
1 parent 365f802 commit 33a3295
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version = 1.0
version = 1.1.0
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@
public final class DataSourceDestination implements Destination {
private final DataSource dataSource;

/**
* Constructor
* @param dataSource the wrapped DataSource
*/
public DataSourceDestination(@Nonnull DataSource dataSource) {
Preconditions.checkNotNull(dataSource, "dataSource may not be null");
this.dataSource = dataSource;
}

/**
* Factory method creating a new DataSourceDestination. This allows a more readable style than using the
* constructor:
Expand All @@ -66,15 +75,6 @@ public static DataSourceDestination with(@Nonnull DataSource dataSource) {
return new DataSourceDestination(dataSource);
}

/**
* Constructor
* @param dataSource the wrapped DataSource
*/
public DataSourceDestination(@Nonnull DataSource dataSource) {
Preconditions.checkNotNull(dataSource, "dataSource may not be null");
this.dataSource = dataSource;
}

@Override
public Connection getConnection() throws SQLException {
return dataSource.getConnection();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,19 @@ public final class DriverManagerDestination implements Destination {
private final String user;
private final String password;

/**
* Constructor
* @param url the URL of the database
* @param user the user used to get a connection
* @param password the password used to get a connection
*/
public DriverManagerDestination(@Nonnull String url, String user, String password) {
Preconditions.checkNotNull(url, "url may not be null");
this.url = url;
this.user = user;
this.password = password;
}

/**
* Factory method creating a new DriverManagerDestination. This allows a more readable style than using the
* constructor:
Expand Down Expand Up @@ -71,19 +84,6 @@ public static DriverManagerDestination with(@Nonnull String url, String user, St
return new DriverManagerDestination(url, user, password);
}

/**
* Constructor
* @param url the URL of the database
* @param user the user used to get a connection
* @param password the password used to get a connection
*/
public DriverManagerDestination(@Nonnull String url, String user, String password) {
Preconditions.checkNotNull(url, "url may not be null");
this.url = url;
this.user = user;
this.password = password;
}

@Override
public Connection getConnection() throws SQLException {
return DriverManager.getConnection(url, user, password);
Expand Down

0 comments on commit 33a3295

Please sign in to comment.