[MOYEO-68] 볼륨 on/off 아이콘 추가 & 리드미 수정 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
685d86e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0554ca5d.moyeomoyeo.pages.dev |
| Branch Preview URL: | https://feature-moyeo-68.moyeomoyeo.pages.dev |
young-do
approved these changes
Aug 21, 2023
README.md
Outdated
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <a href="https://forms.gle/SScnNAsaziQWfCi89" style="font-style:italic; font-size:18px; color:#8060FF">귀여운 캐릭터들 이름 추천 받아요~!</a> |
There was a problem hiding this comment.
style 속성이 지워지는듯! i 태그를 감싸는건 어때?
Comment on lines
+81
to
+85
| {isPlayedBackgroundMusic ? ( | ||
| <VolumeOnIcon width="25px" height="25px" /> | ||
| ) : ( | ||
| <VolumeOffIcon width="25px" height="25px" /> | ||
| )} |
There was a problem hiding this comment.
이렇게 하는것도 괜찮다~!
나중에 svg width, height 전달하는거 통일하면 좋을 듯 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
-볼륨 on/off 아이콘 추가
-readme에 캐릭터 추가
체크리스트