Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[온보딩] 로그인 화면 #60

Merged
merged 8 commits into from
Aug 21, 2023
Merged

[온보딩] 로그인 화면 #60

merged 8 commits into from
Aug 21, 2023

Conversation

k906506
Copy link
Contributor

@k906506 k906506 commented Aug 15, 2023

이슈 번호

설명

  • 카카오 로그인
    • Escaping Closure에서 Reducer State를 변경할 수 없어서 withCheckedThrowingContinuation로 Async/Await 타입으로 변경해서 구현했어!
  • 애플 로그인
    • View에서 Auth 인스턴스를 생성해서 넘겨주고 있는데 추후에 구조 다시 잡으면서 수정 예정!
  • 어떻게든 TCA 맞춰보려고 했는데... 쉽지 않네 ㅎㅎ

@k906506 k906506 added the enhancement New feature or request label Aug 15, 2023
@k906506 k906506 requested review from enebin and 0inn August 15, 2023 23:36
@k906506 k906506 self-assigned this Aug 15, 2023
@k906506 k906506 changed the title Feature/sign in view(#19) [온보딩] 로그인 화면 Aug 16, 2023
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

언제나 쉽지 않은 TCA . .
고생하셨습니다 ! ! 👍🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 이미지 안깨지나 ?
@3x까지 넣으면 좋을 듯 !

Projects/Network/Sources/Network/Foundation/KeymeAPI.swift Outdated Show resolved Hide resolved
Comment on lines 19 to 32
public var baseURL: URL {
return URL(string: "https://randomuser.me")!
return URL(string: "https://api.keyme.space")!
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 이미 baseURL 바꿔둬서 해당 baseURL 필드 아예 지워도 될 듯 !

@enebin
Copy link
Member

enebin commented Aug 21, 2023

뒷작업 때문에 일단 머지하고 수정 진행할게요~

@enebin enebin merged commit 17f08de into develop Aug 21, 2023
1 check passed
@enebin enebin deleted the feature/sign-in-view(#19) branch August 23, 2023 04:07
@enebin enebin mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants