Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase, Swiftlint 오작동 수정 #34

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

enebin
Copy link
Member

@enebin enebin commented Aug 10, 2023

@enebin enebin self-assigned this Aug 10, 2023
@enebin enebin requested review from 0inn and k906506 and removed request for 0inn August 10, 2023 06:39
@@ -27,7 +27,7 @@ extension Project {
sources: ["Sources/**"],
resources: [.glob(pattern: "Resources/**", excluding: [])],
entitlements: .relativeToRoot("Keyme.entitlements"),
scripts: Project.script,
scripts: Project.lintScript + Project.encryptionScript,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

얘는 원래 다른 프로젝트에 encrypt 빼고 Lint만 하려는 의도로 분리해 놨음. 지금은 한 프로젝트에만 스크립트를 사용해서 딱히 의미가 없는데 거시적 관점으로 나눠놓는 것도 좋아 보여서 일단 유지해놨어..!

@enebin enebin added the bug Something isn't working label Aug 10, 2023
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 👍🏻🚀

Copy link
Contributor

@k906506 k906506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당~

@enebin enebin merged commit b5a7c2d into develop Aug 10, 2023
@enebin enebin deleted the fix/some-bugs(#32,#33) branch August 10, 2023 06:55
This was linked to issues Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swiftlint 옵션 수정 Firebase 빌드 오류 수정
3 participants