Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Login 화면 Loading Indicator 위치 조정 #131

Merged
merged 3 commits into from
Apr 5, 2024
Merged

[FIX] Login 화면 Loading Indicator 위치 조정 #131

merged 3 commits into from
Apr 5, 2024

Conversation

easyhooon
Copy link
Collaborator

  • Login 화면의 Loading Indicator 가 보이지 않던 이슈가 있었는데, 왼쪽 상단에 있어서 안보였던 거 엿음.. 중앙으로 위치 조정
  • Create Image 모듈 내에 Route 네이밍 변경
    • Create Image Navigation 모듈의 Route 를 create_route 로, Create Image Screen 화면의 Route 를 create_image_route 로(반대로 매핑되어있었음)

@easyhooon
[CHORE] Create Image 모듈 Route 네이밍 변경
f06c5e9 
CreateImage Navigation 의 route 를 create_route 로, CreateImageScreen 의 route 를 create_image_route 로 변경
@easyhooon
[FIX] 로그인 화면 Loading Indicator 위치 조정
89f1653 
Loading Indicator 가 안보이던게 아니라, 왼쪽 상단에 위치해 있던거였음...
@easyhooon easyhooon added bug Something isn't working design tasks related to design aspects of the project labels Apr 5, 2024
@easyhooon easyhooon requested a review from josushell April 5, 2024 19:10
@easyhooon easyhooon self-assigned this Apr 5, 2024
josushell
josushell approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@josushell josushell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@easyhooon easyhooon merged commit 17691a9 into develop Apr 5, 2024
1 check passed
@easyhooon easyhooon deleted the fix/chore-detail branch April 5, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josushell josushell josushell approved these changes

Assignees

@easyhooon easyhooon

Labels
bug Something isn't working design tasks related to design aspects of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easyhooon @josushell