Chore/#263 종료된 공연 DIM 처리 변경 및 티켓 상세페이지 자동 하이라이팅 적용 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wngus4296
approved these changes
Jul 3, 2024
wngus4296
reviewed
Jul 3, 2024
| make.horizontalEdges.equalTo(self.titleLabel) | ||
| make.bottom.equalToSuperview().inset(20) | ||
| } | ||
| } | ||
|
|
||
| func setData(with text: String) { | ||
| self.noticeLabel.text = text | ||
| self.noticeTextView.text = text |
There was a problem hiding this comment.
여기 아마 textView에 텍스트 height 적용이 안되고 있을 거라서 행간 확인이 필요할 것 같아!!
Suggested change
| self.noticeTextView.text = text | |
| self.noticeTextView.text = text | |
| self.noticeTextView.setLineSpacing(lineSpacing: 6) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용
스크린샷
관련 이슈